-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sender for Zabbix trapper items #194
base: master
Are you sure you want to change the base?
Conversation
Just a thought: It is pretty feature-rich: it supports PSK encryption and bulk sending from files with active node selection (for HA in Zabbix 6.0)and more on the way. |
Oh didn't knew about this project. I am all for joining the different projects together. I think you are right we should probably merge your project instead of the one at adubkov/py-zabbix. Do you have write permission on this repository ? If not maybe @lukecyca could give it to you so you still have a hand on your project. We might need to write some migrations guide for users coming from both py-zabbix or zappix. |
I do not have such permissions and it would be nice if I could keep developing it as I had up to this point.
I'll most likely introduce some breaking changes during the import, so a guide would be in place. Are we aiming for any interface compatibility or are we going only for feature parity? This will impact some design decisions.
Depends on the deadline. If you want do finish it by the end of next week, then no. Should we setup a gitter or something similar moving forward? |
Agreed, we have to think of a clean structure so we properly split/namespace each features.
I think we should aim for unifying all the duplicate code bases. The initial idea was to reach feature parity with adubkov/py-zabbix so we could solve this namespace issue. But since they are other more advanced project such as yours that could fit instead, I am all for putting all the effort in a single package.
We can plan some discussions to be on the same page and having this done by end august seem doable, but I am not sure I'll be able to follow a deadline if we set any. Not sure we need one.
I am on matrix.org @ |
Given that we want to combine 3 projects into a single one, I'm worried that the namespace will be bloated.
Would this be easy to use by everyone? Good to know we're in no hurry to unify all packages - a rushed design would probably result in failure.
Should we move this discussion to a ticket then? A PR is not the obvious place to look for such discussions. |
Reach feature parity with adubkov/py-zabbix.