break: do not decode req.path by default

[benmccann]

Fixes #142

[lukeed]

I have this change locally, but with some performance optimizations too.

On its own, decodeURIComponent is expensive & needs to be done sparingly. But this (the suggestion) can land in the meantime before those optimizations are ready to land.

[codecov-commenter]

Codecov Report

Merging #172 (83751fb) into next (4885177) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              next      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          105       107    +2     
=========================================
+ Hits           105       107    +2     

Impacted Files	Coverage Δ
packages/polka/index.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4885177...83751fb. Read the comment docs.

[lukeed]

Just for the record, the effect of this PR:

# before

Running 10s test @ http://localhost:3000/
  4 threads and 4 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   115.46us  161.68us   8.41ms   97.94%
    Req/Sec     9.28k     1.71k   12.81k    73.27%
  372959 requests in 10.10s, 45.17MB read
Requests/sec:  36927.84
Transfer/sec:      4.47MB

# after

Running 10s test @ http://localhost:3000/
  4 threads and 4 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   147.72us  204.77us  11.45ms   97.27%
    Req/Sec     7.46k     1.43k   11.18k    73.51%
  299801 requests in 10.10s, 36.31MB read
Requests/sec:  29683.11
Transfer/sec:      3.60MB

[lukeed]

After the linked commit:

Running 10s test @ http://localhost:3000/
  4 threads and 4 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   109.20us   53.27us   1.68ms   90.50%
    Req/Sec     9.22k     1.49k   12.64k    67.57%
  370649 requests in 10.10s, 44.89MB read
Requests/sec:  36800.70
Transfer/sec:      4.46MB