WIP: Schema revision #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @danixeee!. As mentioned in secure-systems-lab#163 (comment), I'd rather keep this separate from secure-systems-lab#174 (we really have to check the consequences for TUF first). So I won't merge it into |
|
@lukpueh I forgot to mention that I created this PR so you can easily see the changes (I also forgot that it's possible to compare between different fork's branches :) ). I will create a PR to securesystemslib now. Update: Here is the PR: secure-systems-lab#176. |
lukpueh
force-pushed
the
add-gpg
branch
2 times, most recently
from
3be032c
to
ad996ea
Compare
Largely resolves Issue secure-systems-lab#161, especially given the merge of PR secure-systems-lab#162. See GitHub: secure-systems-lab#161 secure-systems-lab#162 Signed-off-by: Sebastien Awwad <[email protected]>
The following functions in securesystemslib.util are not used anywhere, not in securesystemslib, not in TUF, and not in in-toto: - find_delegated_roles - ensure_all_targets_allowed - paths_are_consistent_with_hash_prefixes In addition, the first two are also clearly TUF-specific (and the third is a close call). So I'm removing them all. This commit also removes their tests. Signed-off-by: Sebastien Awwad <[email protected]>
This follows from the commit with subject: "Removes TUF-specific formats from formats.py" It: - removes testing for schemas that were removed by that commit (TUF-specific or otherwise unnecessary schemas) - corrects uses of the deleted RELPATH_SCHEMA to PATH_SCHEMA and RELPATHS_SCHEMA to PATHS_SCHEMA Signed-off-by: Sebastien Awwad <[email protected]>
sys and fnmatch are no longer needed due to the removal of unused functions in prior commits. Signed-off-by: Sebastien Awwad <[email protected]>
Signed-off-by: Sebastien Awwad <[email protected]>
and also marks the DecompressionError exception for possible future removal (alongside the compression-related functions). Signed-off-by: Sebastien Awwad <[email protected]>
Also remove now obsolete util.HASH_FUNCTION and corresponding tests. The function is added back to tuf in theupdateframework/python-tuf#909.
…ve_out_tuf_formats Removes unused and TUF-specific content from securesystemslib
Add gpg support and custom (sub)process module
danixeee
force-pushed
the
danixeee/schema-revision
branch
4 times, most recently
from
de9a750
to
001ed1d
Compare
danixeee
force-pushed
the
danixeee/schema-revision
branch
from
402fa06
to
1bc1767
Compare
|
Closing this one. It's merged to origin repo via secure-systems-lab#176. |
lukpueh
pushed a commit
that referenced
this pull request
Jun 5, 2023
Added packages to requirements and a small bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
This PR modifies formats in order to support GPG keys.
Signature verification function is also modified to allow passing GPG public key format.
Please verify and check that the pull request fulfills the following
requirements: