LSP19 Social Registry #154
Conversation
| "hash": "Bytes32" // The hash of the post object | ||
| } | ||
| ], // The identifier (hash) of all the posts this account has liked, | ||
| "dislikes": [ |
There was a problem hiding this comment.
Facebook consciously decided against dislikes. It would be good to look into that reasoning before adding this here.
There was a problem hiding this comment.
We also did not use it in our Lookso project, as we don't find it relevant. However, we thought it might be important proposing a really complete and flexible standard, in order for people to be able to build any kind of social app they want on top of that. For instance, it might be relevant for people doing a Youtube or Reddit like DApp
|
Amazing. Thanks for that. I’ll comment on the structure once I had the time to have a proper look at it. |
|
I think messages should contain a signature, even with the issue, that the signing key might not be present anymore at the UP in some point in the future, but there are use cases where signing a message is the only way (maybe no validator was used, for example) |
Yes indeed, we took it out of our flow as we think it's not useful in our case. But it would be indeed good adding it to the standard. I'll commit it |
samuel-videau
force-pushed
the
feat/LSP19_Social_Registry
branch
from
c6bd51a
to
3048a0e
Compare
|
@frozeman the |
There was a problem hiding this comment.
@samuel-videau very great proposals! I remember it from the Hackathon indeed!
I have added some review comments :)
|
|
||
| ## Abstract | ||
|
|
||
| This standard defines a set of data formats and a key-value pair to create a Social Media Feed, combining [ERC725Account](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-0-ERC725Account.md) and an open distributed storage network such as [IPFS](https://ipfs.tech/) or [ARWEAVE](https://arweave.org). |
There was a problem hiding this comment.
Maybe?
| This standard defines a set of data formats and a key-value pair to create a Social Media Feed, combining [ERC725Account](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-0-ERC725Account.md) and an open distributed storage network such as [IPFS](https://ipfs.tech/) or [ARWEAVE](https://arweave.org). | |
| This standard defines a set of data formats and a key-value pair to create a decentralised Social Media Feed, combining [LSP0-ERC725Account](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-0-ERC725Account.md) and an open distributed storage network such as [IPFS](https://ipfs.tech/) or [ARWEAVE](https://arweave.org). |
| ## Abstract | ||
|
|
||
| This standard defines a set of data formats and a key-value pair to create a Social Media Feed, combining [ERC725Account](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-0-ERC725Account.md) and an open distributed storage network such as [IPFS](https://ipfs.tech/) or [ARWEAVE](https://arweave.org). | ||
| It also defines a smart contract used to guaranty authenticity and timestamp of a post. |
There was a problem hiding this comment.
| It also defines a smart contract used to guaranty authenticity and timestamp of a post. | |
| It also defines a smart contract that can be used to guaranty authenticity and timestamp of a post. |
| This standard defines a set of data formats and a key-value pair to create a Social Media Feed, combining [ERC725Account](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-0-ERC725Account.md) and an open distributed storage network such as [IPFS](https://ipfs.tech/) or [ARWEAVE](https://arweave.org). | ||
| It also defines a smart contract used to guaranty authenticity and timestamp of a post. | ||
|
|
||
| ## Motivation |
There was a problem hiding this comment.
Super the motivation section 👌 Very on point!
|
|
||
| ### LSP19SocialRegistry | ||
|
|
||
| A Universal Profile's Social Media State will live under a record referenced by the "LSP19SocialRegistry" data key of their ERC725Y store. |
There was a problem hiding this comment.
Maybe we can keep it generic here? As Universal Profile could be one of the type of contracts that use it, but we don't know yet which other type of contracts could use it.
| A Universal Profile's Social Media State will live under a record referenced by the "LSP19SocialRegistry" data key of their ERC725Y store. | |
| A Social Media State (for instance the one of a Universal Profile) will live under a record referenced by the "LSP19SocialRegistry" data key of their ERC725Y store. |
| } | ||
| ``` | ||
|
|
||
| This registry should be updated everytime a new post is added by the user. |
There was a problem hiding this comment.
Let's ensure the standard verbs are in uppercase.
| This registry should be updated everytime a new post is added by the user. | |
| This registry SHOULD be updated everytime a new post is added by the user. |
| A Profile Post can be an original message, a comment on another post or a repost. The JSON file should have the following format: | ||
|
|
||
| Not all fields are required. For example, a `repost` doesn't need a message, but it should have the `url` and `hash` to the original post. | ||
| The `LSP19ProfilePostSignature` property is optional and depends on the use case. It is used to authenticate a post through a controller EOA (Externally Owned Account) |
There was a problem hiding this comment.
Does it has to be an EOA? Can't it be another 🆙 ? 😉
| The `LSP19ProfilePostSignature` property is optional and depends on the use case. It is used to authenticate a post through a controller EOA (Externally Owned Account) | |
| The `LSP19ProfilePostSignature` property is OPTIONAL and depends on the use case. It is used to authenticate a post through a controller EOA (Externally Owned Account) |
There was a problem hiding this comment.
Hmm what do you mean ?
| "LSP19ProfilePost": { | ||
| "version": "0.0.1", // The Metadata version of this post | ||
| "author": "Address", // The Universal Profile who authored the post | ||
| "locale": "string", // language code - Country Code (de_DE) |
There was a problem hiding this comment.
Might be good to be consistent. Above, strings are mentioned as String (uppercase S).
| } | ||
| ], | ||
| "assets": [ | ||
| "interface": "string" // Contract interface |
There was a problem hiding this comment.
Maybe here you could provide the option to be either:
- a contract interface name (e.g:
ILSPN...) - or a bytes4 interface identifier (e.g:
0x3e89ad98for LSP0 interface).
| "interface": "string" // Contract interface | |
| "interface": "string | bytes4" // Contract interface |
There was a problem hiding this comment.
Actually it might maybe be good having both
| ```js | ||
| { | ||
| "LSP19ProfilePost": { | ||
| "version": "0.0.1", // The Metadata version of this post |
There was a problem hiding this comment.
Might be good to add a sentence in the standard to describe this field.
| * @notice A validator tailored for Universal Profiles and content publishing | ||
| * @dev Writes to the Universal Profile key/value store | ||
| */ | ||
| contract LSP19PostValidator is Context { |
There was a problem hiding this comment.
Is there a standard interface for the contract (some standard functions), or it could be implemented in any way.
I am asking as the title says:
And from my understanding, I thought it would also include an interface (set of functions).
There was a problem hiding this comment.
Hmm ideally, there would be only one of this contract deployed, that everybody would use, it actually doesn t really make sense having multiple instances of this contract deployed, apart making the verification process a bit harder.
|
We will revisit that later. This will be relevant for droops and universalprofile.cloud. |
Sounds good! We also need to dive back in, can be a good topic discussion in Istanbul :) |
@AntonioPMCS and myself are finally proposing the LIP we used in our Hackathon project LOOKSO.
It will probably need edits, but we decided to PR it, in order to progress on the subject.
Happy New Year! 🎉