Feature/cleanup and resolution update #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good, I'll take these changes in and keep in mind the areas that need refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got rid of all the duplicated calls to the detection service.. and I think fixed a bug for manual recording.
I think it was possible for the
currentSession.Pidto be set to a non zero value in failed manual recording attempts. I also changed how manual recording works.. instead of doing any checks if there is a game to record, it'll force an attempt to record the window in focus. I'm not fully happy with this PR tbh, I think some refactoring could be done.. lines 134-144 for example are copy pasted fromWinEventProc