-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TRAC-18-Upgrade-axios-version-in-node-tracer #514
feat: TRAC-18-Upgrade-axios-version-in-node-tracer #514
Conversation
This reverts commit 973fef6.
This reverts commit d46c461.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated PR to reflect latest comments
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
===========================================
- Coverage 100.00% 99.34% -0.66%
===========================================
Files 19 42 +23
Lines 1165 2734 +1569
Branches 246 761 +515
===========================================
+ Hits 1165 2716 +1551
- Misses 0 17 +17
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approved, just minor notes about the comments
# [1.101.0](v1.100.2...v1.101.0) (2024-09-16) ### Features * TRAC-18-Upgrade-axios-version-in-node-tracer ([#514](#514)) ([8d2bd9f](8d2bd9f))
🎉 This PR is included in version 1.101.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes proposed
Upgrade to https://www.npmjs.com/package/axios/v/1.7.7
Note to reviewers
We have a problem with [email protected] running on Node18 on Jest with [email protected]
We had to move part of fetch.test.js to fetchUtils.test.js to run the test without jest-fetch-mock on Node18