Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TRAC-18-Upgrade-axios-version-in-node-tracer #514

Merged

Conversation

eugene-lumigo
Copy link
Collaborator

@eugene-lumigo eugene-lumigo commented Sep 12, 2024

Changes proposed

Upgrade to https://www.npmjs.com/package/axios/v/1.7.7

Note to reviewers

We have a problem with [email protected] running on Node18 on Jest with [email protected]
We had to move part of fetch.test.js to fetchUtils.test.js to run the test without jest-fetch-mock on Node18

@eugene-lumigo eugene-lumigo changed the title TRAC-18-Upgrade-axios-version-in-node-tracer-ci-debug TRAC-18-Upgrade-axios-version-in-node-tracer Sep 12, 2024
Eugene Orlovsky added 2 commits September 13, 2024 12:03
src/hooks/fetchUtils.test.ts Show resolved Hide resolved
src/hooks/fetchUtils.test.ts Outdated Show resolved Hide resolved
src/hooks/fetchUtils.test.ts Outdated Show resolved Hide resolved
jest.config.js Outdated Show resolved Hide resolved
Copy link
Contributor

@sagivoululumigo sagivoululumigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Copy link
Collaborator Author

@eugene-lumigo eugene-lumigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR to reflect latest comments

@eugene-lumigo eugene-lumigo changed the title TRAC-18-Upgrade-axios-version-in-node-tracer feat: TRAC-18-Upgrade-axios-version-in-node-tracer Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.34%. Comparing base (4e438b5) to head (9b59ab6).
Report is 567 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #514      +/-   ##
===========================================
- Coverage   100.00%   99.34%   -0.66%     
===========================================
  Files           19       42      +23     
  Lines         1165     2734    +1569     
  Branches       246      761     +515     
===========================================
+ Hits          1165     2716    +1551     
- Misses           0       17      +17     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sagivoululumigo sagivoululumigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approved, just minor notes about the comments

@eugene-lumigo eugene-lumigo merged commit 8d2bd9f into master Sep 16, 2024
12 of 13 checks passed
@eugene-lumigo eugene-lumigo deleted the TRAC-18-Upgrade-axios-version-in-node-tracer-ci-debug branch September 16, 2024 14:16
lumigo-circleci-github-user pushed a commit that referenced this pull request Sep 16, 2024
# [1.101.0](v1.100.2...v1.101.0) (2024-09-16)

### Features

* TRAC-18-Upgrade-axios-version-in-node-tracer ([#514](#514)) ([8d2bd9f](8d2bd9f))
@doriaviram
Copy link
Contributor

🎉 This PR is included in version 1.101.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants