Fixed payment bug of revisiting old product #4
Conversation
| configuration_helpers = request.site.siteconfiguration.edly_client_theme_branding_settings | ||
| url = configuration_helpers.get('LUMSXPAY_VOUCHER_API_URL') | ||
|
|
||
| if request.user.is_anonymous or not (url and request.basket): | ||
| if request.user.is_anonymous or not (url and basket): |
There was a problem hiding this comment.
why not wrap inside login_required decorator?
There was a problem hiding this comment.
For classes, we can use LoginRequiredMixin
| course_ids = [] | ||
| def get_existing_basket_challan(self, request): | ||
| basket = request.basket | ||
| product = basket.lines.first().product |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -130,6 +130,8 @@ class Meta(object): | |||
|
|
|||
| class BasketChallanVoucher(TimeStampedModel): | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mumerfarooq000
force-pushed
the
umerF/lums-135/fix-payment-bug
branch
from
f34f0c6
to
f05b28f
Compare
| course_ids = [] | ||
| def get_existing_basket_challan(self, request): | ||
| basket = request.basket | ||
| product = basket.lines.first().product |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| configuration_helpers = request.site.siteconfiguration.edly_client_theme_branding_settings | ||
| url = configuration_helpers.get('LUMSXPAY_VOUCHER_API_URL') | ||
|
|
||
| if request.user.is_anonymous or not (url and request.basket): | ||
| if request.user.is_anonymous or not (url and basket): |
There was a problem hiding this comment.
For classes, we can use LoginRequiredMixin
mumerfarooq000
force-pushed
the
umerF/lums-135/fix-payment-bug
branch
from
4bcf21d
to
79c0681
Compare
Old product was often revisit when buying new product which was logical error as basket line is not newly created but updated by vanilla edx. so bit change of logic and introducing product column was only way to solve it with least coding changes.