Remove private: false from package.json
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We reference this package with `git+https:`. @0bex0 is getting a checksum error when installing it as dependency. This issue has occured before: yarnpkg/berry#2399. I inspected the zipped packages and noticed the difference is `private:` in package.json. I have therefore decided to remove the attribute and see what happens.
rbruggem
requested review from
a team,
jstasiak,
raguiar9080,
charcarr,
0bex0 and
jasharifestina
raguiar9080
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
I skimmed through the linked thread and this was the one comment that caught my eye: yarnpkg/berry#2774 (comment)
Feels very weird if this private change is the issue tbh 🤔 but not like I got a better idea and the change seems benign
It is the cause. I am not sure this change is the fix. We'll see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We reference this package with
git+https:.@0bex0 is getting a checksum error when installing it as dependency.
This issue has occured before: yarnpkg/berry#2399.
I inspected the zipped packages and noticed the difference is
private:in package.json.I have therefore decided to remove the attribute and see what happens.