replace secp256k1 with bcrypto#secp256k1

[faustbrian]

Possibly addresses #13 as I am currently experiencing this issue which makes it impossible to sign transactions with a server-side application.

[faboweb]

Does this work in the browser?

[faustbrian]

I tried it briefly in chrome and had no issues due to bcrypto also having browser bindings https://github.com/bcoin-org/bcrypto/blob/master/package.json#L95 but would appreciate someone else testing.

Also, could forks be enabled on CircleCI so that the tests could run?

[faustbrian]

There 2 more things that could be done to streamline things a bit.

1. Create a node and browser build to keep things separate.
2. Replace crypto-js with bcrypto methods to rely only on a single dependency for crypto.

[Bitcoinera]

I tested this with couple different networks on the browser and it is working great.

Awesome job @faustbrian !

[faboweb]

Doing a release later. Good idea about the steps reduction! From a developer experience perspective I would avoid two builds if not necessary. What is your reasoning for having 2?

[faustbrian]

I generally like to keep browser and node.js builds separated to avoid having dependencies or polyfills included that would be useless for node.js or could potentially even cause issues with making wrong assumptions about the environment and its data types.

[faboweb]

I published the package

[faboweb]

I generally like to keep browser and node.js builds separated to avoid having dependencies or polyfills included that would be useless for node.js or could potentially even cause issues with making wrong assumptions about the environment and its data types.

good argument. happy about a PR doing though. Rn we are a bit busy with other things.

[faustbrian]

I generally like to keep browser and node.js builds separated to avoid having dependencies or polyfills included that would be useless for node.js or could potentially even cause issues with making wrong assumptions about the environment and its data types.

good argument. happy about a PR doing though. Rn we are a bit busy with other things.

Will try to find some time for it in the next days.