Fix app not recovering from failed Gaia initialization #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #483 +/- ##
===========================================
+ Coverage 78.98% 79.01% +0.03%
===========================================
Files 82 82
Lines 1318 1320 +2
Branches 68 68
===========================================
+ Hits 1041 1043 +2
Misses 259 259
Partials 18 18
|
jbibla
reviewed
Feb 16, 2018
| @@ -328,6 +328,28 @@ function consistentConfigDir (appVersionPath, genesisPath, configPath, gaiaVersi | |||
| exists(gaiaVersionPath) | |||
| } | |||
|
|
|||
| // check if baseserver is initialized as the configs could be corrupted | |||
| // we need to parse the error on initialization as there is no way to just get this status programmatically | |||
There was a problem hiding this comment.
should we ask gaia to return the status programatically (in the future)?
There was a problem hiding this comment.
in theory this would be possible. but I think it doesn't have too high priority. Should I create an issue?
There was a problem hiding this comment.
yeah, create an issue. just worries me a bit to depend on parsing the error.
jbibla
approved these changes
Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#334
❤️ Thank you!