Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:Fabo/304 simple config #620

Closed
wants to merge 23 commits into from
Closed

WIP:Fabo/304 simple config #620

wants to merge 23 commits into from

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Apr 6, 2018

Thank you a lot for contributing to Cosmos Voyager!

Issue

closes: #304

Simple version of the much more sophisticated version by David. Just having a config on root level and copying it into the build.

@faboweb faboweb changed the title WIP: Fabo/304 simple config Fabo/304 simple config Apr 6, 2018
@codecov
Copy link

codecov bot commented Apr 6, 2018

Codecov Report

Merging #620 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #620      +/-   ##
===========================================
- Coverage     85.6%   85.58%   -0.02%     
===========================================
  Files           89       89              
  Lines         1507     1505       -2     
  Branches        69       69              
===========================================
- Hits          1290     1288       -2     
  Misses         203      203              
  Partials        14       14
Impacted Files Coverage Δ
app/src/main/index.js 94.93% <ø> (-0.07%) ⬇️
app/src/renderer/vuex/modules/wallet.js 96.15% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/user.js 100% <100%> (ø) ⬆️
app/src/network.js 100% <100%> (ø) ⬆️

@faboweb faboweb changed the title Fabo/304 simple config WIP:Fabo/304 simple config Apr 9, 2018
@faboweb
Copy link
Collaborator Author

faboweb commented Apr 12, 2018

Closed in favor of #604

@faboweb faboweb closed this Apr 12, 2018
@faboweb faboweb deleted the fabo/304-simple-config branch May 29, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass COSMOS_NETWORK env var through in production build
1 participant