peng/518 hide assets not holding

[nylira]

Issue

Closes #518

Screenshots

[faboweb]

In the mocks by Gautier there was a button to show all assets. Do we want that?

[nylira]

I was thinking about that too, having a toggleable button. I concluded its less maintenance for us and simpler for the user to just hide 0 balance tokens. They can't do anything with that data so it'll just be visual noise and additional complexity.

[faboweb]

Your are right. Let's keep it like this then.

[codecov]

Codecov Report

Merging #633 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #633   +/-   ##
========================================
  Coverage    85.62%   85.62%           
========================================
  Files           91       91           
  Lines         1524     1524           
  Branches        69       69           
========================================
  Hits          1305     1305           
  Misses         205      205           
  Partials        14       14

Impacted Files	Coverage Δ
app/src/renderer/components/wallet/PageWallet.vue	85.29% <ø> (ø)	⬆️

[jbibla]

i just want to flag that i believe we agreed to hide and optionally reveal all the denominations on the network.

i'm bringing it up so we can improve our processes - not to revert any changes or propose i'm unsatisfied with this decision.

[faboweb]

Are you not satisfied with the discussion above?

[jbibla]

well, i would have preferred to still show all the denoms on the network. and i worked on a ticket to make this happen. so this is ok - there are good reasons on both sides. i'm just saying we already decided on this a while back, so i'd like us to note that we have an opportunity to improve the way we log and discuss our product design decisions.

[nylira]

@jolesbi I missed the original conversation around the ticket #518. I followed the description on the ticket ("We want to hide tokens, that have a balance of 0 so the user can focus on things that are important."). I didn't know that toggling the tokens was part of the spec, so I didn't implement it to save me some work.

That said, I still believe there's no point in showing tokens to the users they cannot access. On Ethereum wallets and blockchain explorers, they do not show that you have 0 balances of every ERC20 token. On websites that do show 0 balances of supported tokens (like the Poloniex crypto exchange), the page ends up being very long and overloaded with information. For Polo, it is required because each token has its own "receive address". But we only have one receive address in Cosmos.

(the page keeps going)

[faboweb]

I added a ticket so we don't forget to talk about this later on.