Fixed MCUBoot for SPI hanging, manual firmware rollback #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCUBoot fixed for SPI Bus corruption...
In case of Non-Maskable Interrupt (e.g. assertion failure) and Hard Fault, blink 4 times quickly and reboot.
Assertion failure may be due to SPI Bus corruption, which causes SPI Flash access to fail in spiflash_identify() in repos/apache-mynewt-core/hw/drivers/flash/spiflash/src/spiflash.c. Rebooting fixes the SPI Bus corruption.
See Bootloader does not start properly after a watchdog reset/incoherent SPI state #24
Why blink before rebooting? So that we introduce a delay before rebooting, to prevent reboot looping. If PineTime flashes continuously for a long time, it means that the bootloader is stuck in a reboot loop, possibly due to faulty hardware.
Also fixes the checking for manual firmware rollback. Now we need to press and hold at least 1 second, to prevent accidental rollback. During rollback, the screen blinks slowly 4 times before rebooting.