Update tools/check_board_header.py

so that it handles pico_cmake_set_default the same way as cmake/generic_board.cmake does
lurch · Aug 19, 2024 · 34e3cb9 · 34e3cb9
1 parent 568377d
commit 34e3cb9
Showing 1 changed file with 1 addition and 9 deletions.
diff --git a/tools/check_board_header.py b/tools/check_board_header.py
@@ -99,15 +99,7 @@ def read_defines_from(header_file, defines_dict):
                 # check all uppercase
                 if name != name.upper():
                     raise Exception("{}:{}  Expected \"{}\" to be all uppercase".format(board_header, lineno, name))
-                # check for multiply-defined values
-                if name in cmake_default_settings:
-                    if cmake_default_settings[name].value != value:
-                        if board_header_basename != "datanoisetv_rp2040_dsp.h":
-                            raise Exception("{}:{}  Conflicting values for pico_cmake_set_default {} ({} and {})".format(board_header, lineno, name, cmake_default_settings[name].value, value))
-                    else:
-                        if show_warnings:
-                            warnings.warn("{}:{}  Multiple values for pico_cmake_set_default {} ({} and {})".format(board_header, lineno, name, cmake_default_settings[name].value, value))
-                else:
+                if name not in cmake_default_settings:
                    cmake_default_settings[name] = DefineType(name, value, None, lineno)
                 continue