Internationalize using flatpickr #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omments management
…nores the lutece.prod.url property
…ment permission list:
This reverts commit f0483e1.
make adjustments for internationalization; spelling fixes
I18n develop
fix internationalization for some labels
add missing properties to english language resource bundle files
…plugin-appointment into i18n-develop
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr demonstrates internationalization of the appointment plugin by replacing the use of datepicker and datetimepicker with flatpickr. Notably there are no server side changes. Only template and property updates. It requires updated macros from lutece-platform/lutece-core#252.
The pr attempts to be complete, but may not have tested every aspect. At the least i should be able to generate discussion. See the above pr for details on the macros.
On the administrative side, appointments can generally be created, managed, and viewed in a calendar in both English and French. There is still work to do including translating hard coded French and carefully examining all the date formatting and parsing. For example, every single time moment is used to parse a string, the expected format must be set.
Other changes include providing an English translation of appointment.properties as
webapp/WEB-INF/conf/plugins/appointment-en.properties which could be used in an override.
The commit history is a little messy, and we'd be happy to rewrite it.