Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for download-url function on node/storage #110

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Add support for download-url function on node/storage #110

merged 2 commits into from
Jan 20, 2024

Conversation

alperencelik
Copy link
Contributor

The PR aims to add download-url functionality on Proxmox API. Here is the relevant API documentation:

https://pve.proxmox.com/pve-docs/api-viewer/#/nodes/{node}/storage/{storage}/download-url

@alperencelik
Copy link
Contributor Author

I'm not good at naming so I'm open to any ideas for renaming the function.

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fdb95a1) 25.95% compared to head (23c37ac) 25.91%.
Report is 1 commits behind head on main.

Files Patch % Lines
nodes.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   25.95%   25.91%   -0.05%     
==========================================
  Files          15       15              
  Lines        1753     1756       +3     
==========================================
  Hits          455      455              
- Misses       1278     1281       +3     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luthermonson
Copy link
Owner

I'm not good at naming so I'm open to any ideas for renaming the function.

this api endpoint downloads the url to the storage, i think StorageDownloadURL is probably fine and matches the proxmox api

if motivated there are optional params which i think others could find super useful, might be better to refactor and make a DownloadURLOptions struct which you build the post params from and add the optional params

@alperencelik
Copy link
Contributor Author

Thanks for the review! I think adding a struct for covering optional parameters is good idea.

@luthermonson luthermonson merged commit 7eebddd into luthermonson:main Jan 20, 2024
2 of 4 checks passed
@luthermonson
Copy link
Owner

good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants