change to call acquire_vm_cb() in main thread #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the call to acquire_vm_cb() in luv.new_therad() to be made before the thread is created in luv_new_thread().
2 tasks
zhaozg
approved these changes
Oct 27, 2021
|
wait more approve @squeek502 |
squeek502
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the call to
acquire_vm_cb()inluv.new_therad()to be made before the thread is created inluv_new_thread().It doesn't make much sense in
luv, but since I want to pass resources in the main thread before creating a thread inneovim, can you accept this change?