Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Lua integer in thread and async arguments #727

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

javalikescript
Copy link
Contributor

When passing integers, available since Lua 5.3, as thread or async arguments, the value pushed in the thread or async function is a float.

This change adds the integer flavor to the existing Lua number argument.

tests/test-thread.lua Outdated Show resolved Hide resolved
@squeek502 squeek502 requested a review from zhaozg November 3, 2024 09:29
Copy link
Member

@zhaozg zhaozg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CI errors are irrelevant to this PR.

@squeek502
Copy link
Member

The CI failure is due to this assertion failure:

lua: /home/runner/work/luv/luv/src/loop.c:98: luv_walk_cb: Assertion `data && data->ref < 0x1000000' failed.

This is the same assertion discussed in #721. Any idea why it would be getting triggered here?

@Bilal2453
Copy link
Contributor

Sounds like a good time to also look into #723.

@zhaozg
Copy link
Member

zhaozg commented Nov 5, 2024

@squeek502
Copy link
Member

squeek502 commented Nov 5, 2024

That assertion ever failing in our own tests seems like a bad sign (and the changes in #723 would potentially make this a silent failure).

I think it's unrelated to the changes in this PR, though.

EDIT: Continued here: #721 (comment)

@squeek502 squeek502 merged commit 9299a4b into luvit:master Nov 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants