ImgFrame: report camera settings (focus, exposure, iso) #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getLensPosition(), getExposureTime(), getSensitivity() Only the first is implemented for now
(note: lens position may be reported one frame in advance), fix black image when initial manual exposure was set with other controls, fix switching from auto to manual exposure causing the lens to jump to zero (note: the lens is directly set now with manual focus, bypassing 3A)
This was referenced Aug 4, 2021
themarpe
requested changes
Aug 6, 2021
src/pipeline/datatype/ImgFrame.cpp
Outdated
Comment on lines
46
to
48
| int ImgFrame::getExposureTime() const { | ||
| return img.cam.exposureTimeUs; | ||
| } |
There was a problem hiding this comment.
IMO duration would be more applicable in this case
std::chrono::microseconds ImgFrame::getExposureTime() const {
return std::chrono::microseconds(img.cam.exposureTimeUs);
}
themarpe
requested changes
Nov 11, 2021
|
This (newer) PR also includes features added in this PR: #210 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new API which can be used on
ImgFramepackets received from camera:(note: lens position may be reported one frame in advance at the moment)should be fixedFW updates:
(note: the lens is directly set now with manual focus, bypassing 3A) -- was merged previously
WIP, currently only reports values for ColorCamera.- FixedRelated PR: luxonis/depthai-shared#51