Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calib update #1083

Merged
merged 73 commits into from
Aug 11, 2023
Merged

Calib update #1083

merged 73 commits into from
Aug 11, 2023

Conversation

MaticTonin
Copy link
Contributor

  • Clearing the disableRGB,

  • adding the epipolarThreshold parameter and

  • minSyncTimestamp parameter for sync of images from different cameras.

  • Clearing the OAK-D-1 problem with stereo on one camera (line 791)

@@ -129,7 +127,7 @@ def parse_args():
parser.add_argument("-ih", "--invertHorizontal", dest="invert_h", default=False, action="store_true",
help="Invert horizontal axis of the camera for the display")
parser.add_argument("-ep", "--maxEpiploarError", default="0.7", type=float, required=False,
help="Sets the maximum epiploar allowed with rectification")
help="Sets the maximum epiploar allowed with rectification. Default: %(default)s")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this default set to.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is set to 0.7. Should I set it lower?

@saching13
Copy link
Contributor

update this branch to be on-top of main

Copy link
Contributor

@saching13 saching13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

calibrate.py Outdated Show resolved Hide resolved
calibrate.py Outdated Show resolved Hide resolved
@saching13 saching13 merged commit 984ff1f into main Aug 11, 2023
3 checks passed
@saching13 saching13 deleted the calib_update branch August 11, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants