Add DepthAI PreV3 Support for Robothub #27
Conversation
psauxo
force-pushed
the
depthai-preV3-to-rh
branch
from
3a246c3
to
746666f
Compare
psauxo
changed the title
psauxo
force-pushed
the
depthai-preV3-to-rh
branch
from
1f2fe1c
to
ba164f7
Compare
psauxo
force-pushed
the
depthai-preV3-to-rh
branch
from
ba164f7
to
81d7791
Compare
|
@psauxo do we want to merge this into main when its this testing environment that we will replace in the future anyway? |
I think merging into the main branch isn't necessary at this stage. We can leverage the manual triggers in our GitHub Actions workflows to build and push our Docker images into the GitHub registries for testing purposes. I mean to trigger this workflow Our current GitHub workflows setup supports this because on:
workflow_dispatch:
release:
types: [published]Specifically, the IMAGE_REF_NAME: ${{ github.event_name == 'release' && 'robothub-app-v2' || 'robothub-app-v2-dev' }}Additionally, we're using dynamically generated IMAGE_VERSION: ${{ needs.generate-version.outputs.version }}This setup allows us to effectively test our images without impacting the main branch, maintaining flexibility and control necessary for our current development phase. Also, it's worth noting that we can build these images now and use them as base images for our depthai-v3 applications. FROM ghcr.io/luxonis/robothub-app-v2-dev:2024.275.1315-rvc2-depthaiV3-regular
RUN apt update && apt install -y ffmpeg
RUN pip3 install -U av pytz bitstringThis approach allows us to test the images in a real-world scenario and ensure they meet our requirements. If we encounter any issues or need further modifications, we can always make additional changes to this branch before considering a merge into the main branch. My proposal is to manually trigger this workflow now. Once the images are built and published, we can proceed to test them in our depthai-v3 applications. What do you think? @PetrNovota |
This sounds great! |
I have triggered the workflow, all new images are built and published to the registry, you can find new images here |
Add DepthAI PreV3 Support for Robothub
I was trying to make an isolated setup based on the existing docker image setup
depthai-v3-gitdir with the following files:rvc2-depthaiV3intobuild-images-base.shcontext/install-depthai-from-git- used in the previously mentioned Dockerfilesscripts/versions.confBuilt images:
Inside these images: