Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor composition component #1779

Closed
nadar opened this issue Mar 13, 2018 · 0 comments
Closed

Refactor composition component #1779

nadar opened this issue Mar 13, 2018 · 0 comments
Assignees
@nadar
Labels
architecture enhancement

Comments

@nadar
Copy link
Member

nadar commented Mar 13, 2018 •
edited
Loading

Refactor composition component:

  • fixed composition patterns for de_CH which does not work. composition only works with slash currently de/ch
  • Independent resolving option from current request.
  • Remove old bad methods and replace with more readable names
  • Remove composition after set event
  • Remove Application state change from composition and move to luya\web\UrlManager::parseRequest()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadar nadar

Labels
architecture enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nadar