New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply ruff rules TD FIX and ERA on github actions only #118

Open

davidhopkinson26 opened this issue Jul 11, 2023 · 0 comments

Labels

CI

Contributor

davidhopkinson26 commented Jul 11, 2023

want to apply these rules when making a PR but not as part of every commit.

TD - 2 TODOs flagging up. not sure we want this on commit, maybe good for build pipeline though.
https://beta.ruff.rs/docs/rules/#flake8-todos-td

FIX - as above
flake8-fixme

ERA - deletes all commented out code, not sure we want to do this on commit but would be good for build pipeline.
https://beta.ruff.rs/docs/rules/#eradicate-era

davidhopkinson26 added the CI label

adamsardar mentioned this issue

Replace type checks with type guard #120

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment