-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace type checks with type guard #120
Comments
Closely linked with #116 as type hints required for typeguard |
the downside of this would be that we would no longer get the class specific error messages prefixed by self.classname(). This is quite a useful feature when running transformers in a long pipeline so may be a good justification for keeping the current error handling. |
question for investigation - Can we extend typeguard or something similar to check types of columns in pandas dataframes? |
Now that #118 has been cracked, this ticket comes into focus. The other big player in the argument validation world is pydantic and the @validate_call decorator. Comparing the two: Pydantic
Typeguard
|
Beartype is also interesting in this space |
This looks really interesting, will have to give it a try. Especially interested to see type checking extending to dependencies. Thanks for sharing |
Tubular currently has a lot of type checking. This could be replaced with typeguard to simplify the code and reduce test burden.
The text was updated successfully, but these errors were encountered: