Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NearestImputer Update : Remove median imputer when no null #10

Merged
merged 5 commits into from
Sep 29, 2021

Conversation

ClaireF57
Copy link
Contributor

Use Case : When a column has no null when fitting NearestMeandResponseImputer

  • Previously: have the possibility to have a median imputer
  • Now: This triggers an error. Goal is that in case there is no null, the NearestMeandResponseImputer is not the right one to use but directly a median imputer.

Code update :

  • tubular/imputers.py : removed median imputation
  • tests/imputers/test_NearestMeandResponseImputer.py : removed the test concerning use case with median imputation , updated other test to remove default init concerning the use of median imputer as default
  • example/imputers/NearestMeandResponseImputer.ipyng: removed the code associated to the use of median imputer in notebook and put the example to "deprecated"

Copy link
Contributor

@richardangell richardangell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good, thanks, just very minor tidying of github action file needed

.github/workflows/python-package.yml Outdated Show resolved Hide resolved
@richardangell richardangell merged commit e61a1b3 into lvgig:develop Sep 29, 2021
@ClaireF57 ClaireF57 deleted the simplify_nearestimputer branch October 18, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants