Consistent args and base transformers #168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
a) removed columns_set_or_check method from package as this is now redundant
b) fixed ~60 failing unit tests that instantiated transformers without a columns argument (see note below)
c) updated the example notebook to reflect the removal of this functionality
Note on existing implementation tests outside base test suite:
When going to fix broken tests I found that a lot of them were implementation tests. In order to maintain a sensible scope for this feature, my policy was:
If the test is in a test file for one of the transformers I am moving to generic testing: fix it if it isn't covered by generic testing.
Elif the test is/will be covered by the base behaviour tests: delete it - it will be covered at some point once generic testing gets to this module, and until then it's not really adding any value as an implicit test.
Elif the behaviour this implementation test is trying to implicitly test for will not be covered by the base behaviour tests: fix it quickly (with an xfail in mind but didn't need to) and mark testing this behaviour as TODO. Include bringing the test suite up to best practice standards as part of the scope of moving a transformer over to generic testing. Will include in process doc