Generic Tests for CappingTransformer #200
Conversation
… to BaseMappingTransformerInitTests as it is specific to transformers with mappings arg
davidhopkinson26
changed the title
…Created new BaseCappingTransformer class to assist in this
|
Picked this one up to avoid going stale as David is on AL. Did a bit of a refactor of the capping file to make it fit better with the new testing, main change is pulling out shared functionality into 'BaseCapping' class. In the process had to edit OutOfRangeNullTransformer, so scope did creep to updating tests for that one too (sorry!) Did highlight that there are weight checks that can probably be moved into BaseTransformer, or another higher level class. But will leave for another issue. |
There was a problem hiding this comment.
not something for this pr: if we have a chance, would it be better to reorder minimal_attribute_dict to alphabetic order (or anything makes it easier to navigate?)
There was a problem hiding this comment.
Re OtherBaseBehaviourTests, which ones have you spotted that are missing it? think we should be adding
And sure will set up an issue re min attribute dict :)
Adding Generic tests for Capping Transformer.
Realised that the sole test in ColumnsFromDictInitTests is actually specific to Mapping Transformers so have moved this to BAseMappingTransformer tests. Creating a similar test for Capping Transformers to Inherit.