Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated tests for ColumnDtypeSetter (also updated name to fit convent… #219

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

limlam96
Copy link
Contributor

@limlam96 limlam96 commented Apr 5, 2024

…ion)

Links to Issue

Updated testing approach for ColumnDtypeSetter (also updated name to fit convention)

Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Definitely need a changelog update if changing the name of a class though.

@limlam96
Copy link
Contributor Author

Updated changelog here :) 8092a24

(also added an update for a previous PR that I forgot on..)

Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes

@limlam96 limlam96 merged commit 8aa5b2a into main Apr 24, 2024
12 checks passed
@limlam96 limlam96 deleted the feature/update_tests_for_set_dtype_transformer branch April 24, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants