Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored DatetimeInfoExtractor to improve readability/condense #251

Merged
merged 3 commits into from
May 15, 2024
Merged

refactored DatetimeInfoExtractor to improve readability/condense #251

merged 3 commits into from
May 15, 2024

Conversation

limlam96
Copy link
Contributor

Refactored DatetimeInfoExtractor for readability reasons

@limlam96 limlam96 marked this pull request as ready for review May 15, 2024 12:41
davidhopkinson26
davidhopkinson26 previously approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement thanks! Reads more clearly, as advertised. One tiny suggestion but happy for you to ignore and merge as is if you prefer.

@limlam96
Copy link
Contributor Author

Spotted I hadn't updated changelog so pushed again :)

@davidhopkinson26
Copy link
Contributor

Spotted I hadn't updated changelog so pushed again :)

thanks

@limlam96 limlam96 merged commit 6452e83 into main May 15, 2024
12 checks passed
@limlam96 limlam96 deleted the feature/refactor_datetime_info branch May 15, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhopkinson26 davidhopkinson26 davidhopkinson26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limlam96 @davidhopkinson26