Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

started reworking mixin tests #252

Merged
merged 1 commit into from
May 21, 2024
Merged

started reworking mixin tests #252

merged 1 commit into from
May 21, 2024

Conversation

limlam96
Copy link
Contributor

Edited Mixin tests to remove inheritances - this was creating issues with method resolutions order for inheriting from multiple test classes

@limlam96 limlam96 closed this May 21, 2024
@limlam96 limlam96 reopened this May 21, 2024
davidhopkinson26
davidhopkinson26 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, a sensible change.

@davidhopkinson26 davidhopkinson26 merged commit ea6071b into main May 21, 2024
18 checks passed
@davidhopkinson26 davidhopkinson26 deleted the feature/edit_mixin_tests branch May 21, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhopkinson26 davidhopkinson26 davidhopkinson26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limlam96 @davidhopkinson26