Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring MeanResponseTransformer in line with new test set up #262

Merged
merged 16 commits into from
Aug 7, 2024
Merged

Bring MeanResponseTransformer in line with new test set up #262

merged 16 commits into from
Aug 7, 2024

Commits on Jun 27, 2024

  1. 🚧 added test inheritance and removed duplicate/ implementation tests,… 

    … some tests still failing due to tests in base_tests.y not giving a y argument to fit
    @davidhopkinson26
    davidhopkinson26 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2b18ffb View commit details
    Browse the repository at this point in the history

  2. 🚧 updated base_tests where fit being called without y argument, some … 

    …tests still failing so need to investigate
    @davidhopkinson26
    davidhopkinson26 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    8922aa6 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. merge with origin/main

    @davidhopkinson26
    davidhopkinson26 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    15d9919 View commit details
    Browse the repository at this point in the history

  2. fixed test_data.create_object_df to have numeric target in a and chan… 

    …ged affected tests in base_tests.GenericFirTests and GenericTransformTests to refer to df[a] for target
    @davidhopkinson26
    davidhopkinson26 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    8859034 View commit details
    Browse the repository at this point in the history

  3. 📝 update changelog

    @davidhopkinson26
    davidhopkinson26 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f57237b View commit details
    Browse the repository at this point in the history

  4. removed an implementation test from Test_prior_regularisation and ren… 

    …amed to TestPriorRegularisation
    @davidhopkinson26
    davidhopkinson26 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5b5ae21 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. ✅ added test_learnt_values_not_modified back in

    @davidhopkinson26
    davidhopkinson26 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2bcaab0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into mre_test_refactor

    @davidhopkinson26
    davidhopkinson26 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    96fd18a View commit details
    Browse the repository at this point in the history

  3. 🔥 removed default y =None and y type error handling from NearestMeanR… 

    …esponseImputer.fit()
    @davidhopkinson26
    davidhopkinson26 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5632a77 View commit details
    Browse the repository at this point in the history

  4. 🔥 removed duplicate test

    @davidhopkinson26
    davidhopkinson26 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    cd66423 View commit details
    Browse the repository at this point in the history

  5. 🔥 deleted duplicate of test_non_pd_type_error from GenericFitTests

    @davidhopkinson26
    davidhopkinson26 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    e6e990b View commit details
    Browse the repository at this point in the history

  6. modified minimal dataframe for nearestMeanResponseImputer to have 'a'… 

    … as target
    @davidhopkinson26
    davidhopkinson26 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    bfe6649 View commit details
    Browse the repository at this point in the history

  7. 🐛 reconfigured Imputer tests to treat 'a' as target and apply to colu… 

    …mn 'b' by default
    @davidhopkinson26
    davidhopkinson26 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    21186b2 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge remote-tracking branch 'origin/main' into mre_test_refactor

    @davidhopkinson26
    davidhopkinson26 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6fa596a View commit details
    Browse the repository at this point in the history

  2. 📝 fixed changelog

    @davidhopkinson26
    davidhopkinson26 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a8292b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Merge branch 'main' into mre_test_refactor

    @davidhopkinson26
    davidhopkinson26 authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    84d61f9 View commit details
    Browse the repository at this point in the history