Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ScalingTransformer to Inherit from BaseNumericTransformer and Update Tests #284

Merged
merged 12 commits into from
Sep 19, 2024
Merged

Refactor ScalingTransformer to Inherit from BaseNumericTransformer and Update Tests #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
dd0fb45
refactor scalingtransformer class
favouribude1 Jul 23, 2024
a04936c
refactor scalingtransformer class
favouribude1 Jul 23, 2024
878fee8
Refactored ScalingTransformer Test
favouribude1 Sep 9, 2024
84c2393
Refactored ScalingTransformer Test
favouribude1 Sep 9, 2024
8e6e815
Refactored ScalingTransformer Test
favouribude1 Sep 9, 2024
abc889a
Updated changelog
favouribude1 Sep 16, 2024
c2d18dc
Updated changelog
favouribude1 Sep 16, 2024
4a177a7
Updating test for scalingtransformer
favouribude1 Sep 17, 2024
b937ebb
update test
favouribude1 Sep 17, 2024
124bd5b
Added test for scalingtransformer
favouribude1 Sep 17, 2024
4f61a07
update changelog
favouribude1 Sep 17, 2024
b71b72a
remove unnecessary changelog entry for ScalingTransformer column update
favouribude1 Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ Changed
- DatetimeInfoExtractor.mappings_provided changed from a dict.keys() object to list so transformer is serialisable. `#258 <https://github.com/lvgig/tubular/pull/258>`_
- Created BaseNumericTransformer class to support test refactor of numeric file `#266 <https://github.com/lvgig/tubular/pull/266>`_
- Updated testing approach for LogTransformer `#268 <https://github.com/lvgig/tubular/pull/268>`_
- Refactored ScalingTransformer tests in new format `#284 <https://github.com/lvgig/tubular/pull/284>`_


1.3.0 (2024-06-13)
Expand Down
2 changes: 1 addition & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def minimal_attribute_dict():
},
"ScalingTransformer": {
"scaler_type": "standard",
"columns": ["a"],
"columns": ["a", "b"],
},
"SeriesDtMethodTransformer": {
"new_column_name": "a",
Expand Down
Loading
Loading