272 bring cut transformer in line with new test set up #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limlam96
reviewed
Oct 8, 2024
limlam96
approved these changes
Oct 9, 2024
limlam96
deleted the
272-Bring-CutTransformer-in-line-with-new-test-set-up
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted TestInit, TestTransform classes to inherit from base classes & added transformer name class.
I did not identify any extra tests to perform.
I was able to identify several tests to remove that either tested implementation rather than outputs, and those that were inherited from base classes e.g. non-numeric test.
All tests now pass.
Removed numeric check from transformer itself and updated classes to inherit from base classes.