Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added narwhals/polars to env #326

Merged
merged 9 commits into from
Oct 15, 2024
Merged

added narwhals/polars to env #326

merged 9 commits into from
Oct 15, 2024

Conversation

limlam96
Copy link
Contributor

@limlam96 limlam96 commented Oct 9, 2024

preliminary for narwhals milestones

@limlam96 limlam96 mentioned this pull request Oct 10, 2024
Merged
davidhopkinson26
davidhopkinson26 requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions on changes to release pipeline and assumed python verison.

.github/workflows/release.yml Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
davidhopkinson26
davidhopkinson26 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes

@limlam96 limlam96 merged commit b885fc7 into main Oct 15, 2024
10 checks passed
@limlam96 limlam96 deleted the feature/narwhals_mode_imp branch October 15, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhopkinson26 davidhopkinson26 davidhopkinson26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limlam96 @davidhopkinson26