Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dev container #83

Merged
merged 9 commits into from
May 24, 2023
Merged

Feature/dev container #83

merged 9 commits into from
May 24, 2023

Conversation

davidhopkinson26
Copy link
Contributor

@davidhopkinson26 davidhopkinson26 commented May 4, 2023

Adds devcontainer files to project so developers can automatically have an appropriate environment set up in codespaces.

Currently using a python 3.8 container image and then installing requirements-dev.txt. Also installs some default vscode extensions (pylance and gitlens).

Welcome suggestions for other extensions to add by default.

@davidhopkinson26 davidhopkinson26 marked this pull request as ready for review May 4, 2023 15:09
@davidhopkinson26
Copy link
Contributor Author

for some reason black/flake8 are passing on checks but still making changes when I run them locally despite versions being identical. Unsure why and leaving without changes for now.

…ainer.json

updates CONTRIBUTING.rst to reflect changes.
@davidhopkinson26
Copy link
Contributor Author

Considered adding ms-python.black-formatter to default extensions as black formatting on save is a handy feature however:

  • it is in preview
  • it has a minimum supported version of black=23.3.0. This would be ok for now but if it changes in future it could create a conflict.
  • updates are saved as typed in codespaces so unsure how the format on save functionality works in that context

Copy link
Contributor

@Sarah-TaylorKnight Sarah-TaylorKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good and helps out with codespaces! There's a conflict left on CHANGELOG.rst but once that's resolved I'll approve

@davidhopkinson26
Copy link
Contributor Author

All looks good and helps out with codespaces! There's a conflict left on CHANGELOG.rst but once that's resolved I'll approve

fixed in 4d6434e

Copy link
Contributor

@Sarah-TaylorKnight Sarah-TaylorKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks

@davidhopkinson26 davidhopkinson26 merged commit 8eaf1b1 into develop May 24, 2023
@davidhopkinson26 davidhopkinson26 deleted the feature/dev_container branch May 24, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants