-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dev container #83
Conversation
…ip install requirements-dev.txt
for some reason black/flake8 are passing on checks but still making changes when I run them locally despite versions being identical. Unsure why and leaving without changes for now. |
…ainer.json updates CONTRIBUTING.rst to reflect changes.
Considered adding ms-python.black-formatter to default extensions as black formatting on save is a handy feature however:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good and helps out with codespaces! There's a conflict left on CHANGELOG.rst
but once that's resolved I'll approve
fixed in 4d6434e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks
Adds devcontainer files to project so developers can automatically have an appropriate environment set up in codespaces.
Currently using a python 3.8 container image and then installing requirements-dev.txt. Also installs some default vscode extensions (pylance and gitlens).
Welcome suggestions for other extensions to add by default.