Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in setup.py #99

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fixed bug in setup.py #99

merged 1 commit into from
Jul 10, 2023

Conversation

davidhopkinson26
Copy link
Contributor

@davidhopkinson26 davidhopkinson26 commented Jul 10, 2023

bug introduced into setup.py when applying ruff rules. tryign to open context manager with

while open(VERSION_FILE).read()

led to an error because read() does not have an _ enter _ method.

Copy link
Contributor

@Sarah-TaylorKnight Sarah-TaylorKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@davidhopkinson26 davidhopkinson26 merged commit 5564b15 into develop Jul 10, 2023
1 check passed
@davidhopkinson26 davidhopkinson26 deleted the patch/setup branch July 10, 2023 16:04
davidhopkinson26 added a commit that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants