Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preference: customize menubar icon #191

Closed
alt-tab-macos-bot opened this issue Mar 27, 2020 · 4 comments
Closed

Add preference: customize menubar icon #191

alt-tab-macos-bot opened this issue Mar 27, 2020 · 4 comments
Labels
enhancement New feature or request preference Introduction of a new preference

Comments

@alt-tab-macos-bot
Copy link

This issue was opened by a bot after a user submitted feedback through the in-app form.

From: [email protected]

Message:

Hallo und herzlichen Dank für dieses schöne kleine Tool,

ich nutze es erst seit einigen Tagen und bin bisher sehr zufrieden.

Einzig, das Icon Menuleiste für die App ist ziemlich fett, meiner Meinung nach würde es besser aussehen und sich auch besser mit den anderen Icons vertragen wenn es invertiert wäre.

Debug profile:

  • App version: 3.2.1
  • App preferences:
    • NSWindow Frame SUUpdateAlert: Optional(-1270 468 620 392 -1920 -120 1920 1177 )
    • SUAutomaticallyUpdate: Optional(0)
    • SUEnableAutomaticChecks: Optional(1)
    • SUHasLaunchedBefore: Optional(1)
    • SULastCheckTime: Optional(2020-03-27 09:24:42 +0000)
    • SUUpdateRelaunchingMarker: Optional(0)
    • maxScreenUsage: Optional(51)
    • metaKey: Optional(⌥ option)
    • minCellsPerRow: Optional(5)
    • showOnScreen: Optional(Screen including mouse)
    • startAtLogin: Optional(true)
    • tabKeyCode: Optional(48)
    • theme: Optional( macOS)
  • Applications count: 65
  • Windows:
    • {isMinimized: false, isHidden: true, isOnAllSpaces: false, spaceId: 1, spaceIndex: 2}
    • {isMinimized: true, isHidden: false, isOnAllSpaces: false, spaceId: 7, spaceIndex: 3}
    • {isMinimized: false, isHidden: false, isOnAllSpaces: false, spaceId: 9, spaceIndex: 4}
    • {isMinimized: true, isHidden: false, isOnAllSpaces: false, spaceId: 9, spaceIndex: 4}
    • {isMinimized: false, isHidden: false, isOnAllSpaces: false, spaceId: 9, spaceIndex: 4}
    • {isMinimized: true, isHidden: false, isOnAllSpaces: false, spaceId: 9, spaceIndex: 4}
    • {isMinimized: true, isHidden: false, isOnAllSpaces: false, spaceId: 7, spaceIndex: 3}
    • {isMinimized: false, isHidden: false, isOnAllSpaces: false, spaceId: 1, spaceIndex: 2}
    • {isMinimized: false, isHidden: false, isOnAllSpaces: false, spaceId: 1, spaceIndex: 2}
    • {isMinimized: false, isHidden: false, isOnAllSpaces: false, spaceId: 1, spaceIndex: 2}
    • {isMinimized: false, isHidden: false, isOnAllSpaces: false, spaceId: 1, spaceIndex: 2}
    • {isMinimized: false, isHidden: false, isOnAllSpaces: false, spaceId: 1, spaceIndex: 2}
    • {isMinimized: false, isHidden: false, isOnAllSpaces: false, spaceId: 1, spaceIndex: 2}
    • {isMinimized: false, isHidden: false, isOnAllSpaces: false, spaceId: 1, spaceIndex: 2}
  • OS version: Version 10.13.6 (Build 17G10021)
  • OS architecture: x86_64
  • Locale: de_DE (current)
  • Spaces count: 2
  • Hardware model: MacBookPro14,3
  • Displays count: 2
  • CPU model: Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
  • Memory size: 17,18 GB
  • Active CPU count: 8
  • Current CPU frequency: 2.9 Ghz
@mfn
Copy link

mfn commented Mar 29, 2020

Hallo und herzlichen Dank für dieses schöne kleine Tool,

ich nutze es erst seit einigen Tagen und bin bisher sehr zufrieden.

Einzig, das Icon Menuleiste für die App ist ziemlich fett, meiner Meinung nach würde es besser aussehen und sich auch besser mit den anderen Icons vertragen wenn es invertiert wäre.

Translation:

Hi and thank you very much for this nice small tool,

I'm using it since a few days and I'm very happy with it.

However, the icon in the menubar appears very prominent (or: bold/fat(?)), IMHO it would look better if it would have been inverted.

@mfn
Copy link

mfn commented Mar 29, 2020

Interesting feedback and, indeed, also on my system it stands out from all the others I have:
image

@lwouis
Copy link
Owner

lwouis commented Mar 30, 2020

@mfn thank you for the translation! Regarding the icon, having it hollow (black outline instead of black filling) this is a discussion we had with @fturcheti, when he made the beautiful icons for v3. He made the hollow icon, but in the end I found it less consistent on my system that the full one. This is how the icons compare:

image

A pattern I often see for menubar apps is that they let the user pick among a few icon styles, so that people can be satisfied with their preferences. Example with Amphetamine:

image

Or Bartender:

image

I like this idea, and would like to implement it. However there are issues I would consider far more urgent, so for now I can't really focus on cosmetics like this. If anybody wants to raise a PR, I would merge it for sure though! I think this may be best handled by a library as it is quite a standard approach/functionality.

@lwouis lwouis changed the title [In-app feedback] Add preference: customize menubar icon Mar 30, 2020
@lwouis lwouis added enhancement New feature or request preference Introduction of a new preference labels Mar 30, 2020
@mfn
Copy link

mfn commented Mar 30, 2020

A pattern I often see for menubar apps is that they let the user pick among a few icon styles

lol, I've literally never seen this before. #TIL , thanks! :)

@lwouis lwouis closed this as completed in 30f0322 Aug 6, 2020
lwouis pushed a commit that referenced this issue Aug 6, 2020
# [4.14.0](v4.13.1...v4.14.0) (2020-08-06)

### Bug Fixes

* rare crash at launch ([461840e](461840e))

### Features

* can now pick between multiple menubar icons (closes [#191](#191)) ([30f0322](30f0322))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request preference Introduction of a new preference
Projects
None yet
Development

No branches or pull requests

3 participants