v3.3.0 crashed and can no longer be started #202

mrc247-DE · 2020-04-02T11:14:36Z

I update to 3.3.0
Open Settings
App Crashed
I can not start it anymore
I reboot my Mac
I reinstall 3.3.0

but 3.3.0 alway crash and I can not start it anymore :-(

lwouis · 2020-04-02T11:19:17Z

Oh that's terrible! Another user had a similar issue #125 (comment)

If it crashes straight away, I think it may be an issue with reading the preferences. Could you run this command and share the results?

defaults read com.lwouis.alt-tab-macos

Or any crash report or Console.app logs of course would help!

mrc247-DE · 2020-04-02T11:25:08Z

sorry I delete the app with all files and logs and install 3.2.1 again.

lwouis · 2020-04-02T11:26:48Z

No need to downgrade. If it crashes when 3.3.0 is starting, I would like to see what the command I gave above shows, because my first guess would be a preference incompatibility.

janbl · 2020-04-02T11:48:50Z

I have deleted the preferences. Still same crash.
defaults delete com.lwouis.alt-tab-macos

lwouis · 2020-04-02T11:49:03Z

@janbl showed his preferences:

defaults read com.lwouis.alt-tab-macos
{
    "NSWindow Frame SUUpdateAlert" = "1410 557 700 622 0 0 3440 1417 ";
    SUHasLaunchedBefore = 1;
    SULastCheckTime = "2020-04-02 11:17:23 +0000";
    SUUpdateRelaunchingMarker = 1;
    alignThumbnails = Center;
    metaKey = "\\U2318 command";
    startAtLogin = true;
    tabKeyCode = 48;
    theme = "\\Uf8ff macOS";
    windowDisplayDelay = 0;
}

I replicated exactly that on 3.2.1, then started 3.3.0, and nothing crashes. Not sure how to proceed then

lwouis · 2020-04-02T11:49:35Z

I guess it's crashing for another reason. I can't reproduce locally. Do you see any logs in Console.app?

janbl · 2020-04-02T11:51:07Z

Crashed Thread: 0 Dispatch queue: com.apple.main-thread

Exception Type: EXC_BAD_INSTRUCTION (SIGILL)
Exception Codes: 0x0000000000000001, 0x0000000000000000
Exception Note: EXC_CORPSE_NOTIFY

Termination Signal: Illegal instruction: 4
Termination Reason: Namespace SIGNAL, Code 0x4
Terminating Process: exc handler [93589]

Application Specific Information:
Performing @selector(callClosureWithSender:) from sender NSButton 0x7fa24bd86910

Thread 0 Crashed:: 0 com.lwouis.alt-tab-macos 1 com.lwouis.alt-tab-macos 2 com.lwouis.alt-tab-macos 3 com.lwouis.alt-tab-macos 4 com.lwouis.alt-tab-macos 5 com.apple.AppKit 6 com.apple.AppKit 7 com.lwouis.alt-tab-macos 8 com.lwouis.alt-tab-macos 9 com.lwouis.alt-tab-macos 10 com.lwouis.alt-tab-macos 11 com.lwouis.alt-tab-macos 12 com.lwouis.alt-tab-macos 13 com.lwouis.alt-tab-macos 14 com.apple.CoreFoundation 15 com.apple.CoreFoundation 16 com.apple.CoreFoundation 17 com.apple.CoreFoundation 18 com.apple.CoreFoundation 19 com.apple.CoreFoundation 20 com.apple.Foundation 21 com.apple.AppKit 22 com.apple.AppKit 23 com.apple.AppKit 24 com.apple.AppKit 25 com.apple.Foundation 26 com.apple.Foundation 27 com.apple.AE 28 com.apple.AE 29 com.apple.AE 30 com.apple.HIToolbox 31 com.apple.AppKit 32 com.apple.AppKit 33 com.apple.AppKit 34 com.lwouis.alt-tab-macos 35 libdyld.dylib Dispatch queue: com.apple.main-thread
0x000000010695353d specialized static GeneralTab.startAtLoginCallback(:) + 957
0x000000010694964c partial apply for closure #1 in static LabelAndControl.setupControl(:::) + 44
0x000000010694ab4f thunk for @escaping @callee_guaranteed (@guaranteed NSControl) -> () + 15
0x000000010691f2cc SelectorWrapper.callClosure(sender:) + 124
0x000000010691f312 @objc SelectorWrapper.callClosure(sender:) + 34
0x00007fff343df437 -[NSApplication(NSResponder) sendAction:to:from:] + 299
0x00007fff343df2d2 -[NSControl sendAction:to:] + 86
0x00000001069492f5 specialized static LabelAndControl.makeLabelWithCheckbox(::extraAction:labelPosition:) + 1381
0x000000010694da9a static GeneralTab.makeView() + 202
0x000000010694d7d1 static GeneralTab.make() + 177
0x00000001069479d6 PreferencesWindow.setupTabViews() + 86
0x0000000106947963 @objc PreferencesWindow.init() + 227
0x000000010693e752 App.applicationDidFinishLaunching(:) + 1298
0x000000010693e9eb @objc App.applicationDidFinishLaunching(:) + 107
0x00007fff36f159cf CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER + 12
0x00007fff36f15963 ___CFXRegistrationPost1_block_invoke + 63
0x00007fff36f158d8 _CFXRegistrationPost1 + 372
0x00007fff36f15544 ___CFXNotificationPost_block_invoke + 80
0x00007fff36ee56bd -[_CFXNotificationRegistrar find:object:observer:enumerator:] + 1554
0x00007fff36ee4b69 _CFXNotificationPost + 1351
0x00007fff3955b866 -[NSNotificationCenter postNotificationName:object:userInfo:] + 59
0x00007fff341a6153 -[NSApplication _postDidFinishNotification] + 312
0x00007fff341a5e92 -[NSApplication _sendFinishLaunchingNotification] + 208
0x00007fff341a2f53 -[NSApplication(NSAppleEventHandling) _handleAEOpenEvent:] + 549
0x00007fff341a2b98 -[NSApplication(NSAppleEventHandling) _handleCoreEvent:withReplyEvent:] + 688
0x00007fff39586b06 -[NSAppleEventManager dispatchRawAppleEvent:withRawReply:handlerRefCon:] + 308
0x00007fff39586970 _NSAppleEventManagerGenericHandler + 98
0x00007fff38292203 0x7fff38285000 + 53763
0x00007fff38291929 0x7fff38285000 + 51497
0x00007fff38289bd7 aeProcessAppleEvent + 449
0x00007fff35b637fa AEProcessAppleEvent + 54
0x00007fff3419cf31 _DPSNextEvent + 1547
0x00007fff3419b4e0 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1352
0x00007fff3418d1ee -[NSApplication run] + 658
0x000000010691997e main + 62
0x00007fff70e67cc9 start + 1

zoomosis · 2020-04-02T11:51:34Z

Same issue here on OS X 10.14.6.

$ defaults read com.lwouis.alt-tab-macos

{
SUAutomaticallyUpdate = 0;
SUEnableAutomaticChecks = 0;
SUHasLaunchedBefore = 1;
SULastCheckTime = "2020-03-11 16:44:02 +0000";
metaKey = "\U2318 command";
startAtLogin = true;
tabKeyCode = 48;
theme = "\Uf8ff macOS";
}

$ cd /Applications/AltTab.app/Contents/MacOS

$ ./AltTab
"currentSpaceId" 1
"Current space" 1
"Adding app" 15856 "com.apple.loginwindow"
"Adding app" 15912 "com.apple.systemuiserver"
"Adding app" 15911 "com.apple.dock"
"Adding app" 15910 "com.apple.talagent"
"Adding app" 15913 "com.apple.finder"
"Adding app" 15945 "com.apple.notificationcenterui"
"Adding app" 15960 "com.apple.dock.extra"
"Adding app" 15963 "com.apple.CoreLocationAgent"
"Adding app" 15980 "com.apple.Spotlight"
"Adding app" 15982 "com.shauninman.Day-O"
"Adding app" 16008 "com.apple.AirPlayUIAgent"
"Adding app" 16019 "com.apple.locationmenu"
"Adding app" 16038 "com.apple.coreservices.uiagent"
"Adding app" 16013 "com.apple.nbagent"
"Adding app" 15961 "com.apple.wifi.WiFiAgent"
"Adding app" 16063 "com.apple.cloudphotosd"
"Adding app" 16076 "com.brave.Browser"
"Adding app" 16158 "com.googlecode.iterm2"
"Adding app" 16189 "com.lwouis.alt-tab-macos"
"Adding window" 88 "Applications" "com.apple.finder" 1 1
"Adding window" 81 "(2) v3.3.0 crashed and can no longer be started · Issue #202 · lwouis/alt-tab-macos - Brave" "com.brave.Browser" 1 1
"Adding window" 105 "Default (zsh)" "com.googlecode.iterm2" 1 1
zsh: illegal hardware instruction ./AltTab

ghost · 2020-04-02T12:13:37Z

@lwouis As requested in #200, I have checked on my system and have no issues. Running 10.15.4, I have restarted and even changed preferences in Alt-tab but have not had any crashes.

lwouis · 2020-04-02T12:17:52Z

Hard to tell what's wrong here. I'm trying a blind fix with #203

lwouis · 2020-04-02T12:18:37Z

@janbl @zoomosis @mrc247-DE what macOS version are you running on?

janbl · 2020-04-02T12:19:51Z

OS Version: Mac OS X 10.15.4 (19E266)

ghost · 2020-04-02T12:20:26Z

@zoomosis mentioned earlier s/he was on 10.14.6

Same issue here on OS X 10.14.6.

mrc247-DE · 2020-04-02T12:22:37Z

macOS Catalina 10.15.4

lwouis · 2020-04-02T12:25:40Z

Can you guys open the project in XCode perhaps? It's only 3 steps to run the app locally. When you run the app in debug mode and it crashes, it shows you the line and you can understand what's happening way easier since you have the line, the variables on the stack, etc.

In any case, I'm going to merge the blind fixes in #203 as soon as the PR build passes. Maybe that will help

## [3.3.1](v3.3.0...v3.3.1) (2020-04-02) ### Bug Fixes * blind fix trying to guess root cause of [#202](#202) ([fb4fe11](fb4fe11)) * checkboxes preferences were unchecked initially ([b091282](b091282))

lwouis · 2020-04-02T12:41:55Z

I just released v3.3.1. Can you guys try it and share if it fixes the issue for you? 🤞

zoomosis · 2020-04-02T14:15:03Z

3.3.1 seems OK here under OS X 10.14.6. No crash on launch. Thanks!

janbl · 2020-04-02T14:17:23Z

3.3.1. Looks a lot better.
I still face a crash if i click on the start at login checkbox (only that)!

lwouis · 2020-04-02T14:29:29Z

I still face a crash if i click on the start at login checkbox (only that)!

Oh that's really interesting! Thanks for testing and finding this!

Are you checking or unchecking the checkbox?

The issue means something in this function throws an exception:

https://github.com/lwouis/alt-tab-macos/blob/master/src/ui/preferences-window/tabs/GeneralTab.swift#L106

It is quite puzzling since this code hasn't changed much. I wonder if it's something specific to your environment like not enough permissions to delete a login item or something.

Could you please share your login items? Here are mine for instance:

Another potential lead: do you have AltTab in your /Applications folder? What path exactly is AltTab at?

janbl · 2020-04-02T15:05:05Z

Your guess is right, I had an entry with an exclamation mark from an already deleted app in my login items. After deleting the entry your dialog works well. I tried to reproduce the weird entry but was not able to.

lwouis · 2020-04-02T15:45:54Z

@janbl I was able to identify the root cause thank to your help!

Goddamn Apple strikes again:

LSSharedFileListItemCopyResolvedURL can return nil.

The signature is

public func LSSharedFileListItemCopyResolvedURL(_ inItem: LSSharedFileListItem!, _ inFlags: LSSharedFileListResolutionFlags, _ outError: UnsafeMutablePointer<Unmanaged<CFError>?>!) -> Unmanaged<CFURL>!

They forced the result with ! for some reason, so using it in Swift without checking for nullity compiles! But then at runtime it can be nil thus crashing the app. It happens when you have an app in your login items that was removed. It is still listed but the link to the app is broken since the app is no longer in that location.

I'll make a fix for this as soon as possible! 👍

janbl · 2020-04-02T15:48:53Z

Very cool, thanks for the really quick fix.
And thanks for the mouse move feature, I really appreciate that.

lwouis · 2020-04-02T16:14:04Z

Another technical note to document this mess from Apple:

Calling LSSharedFileListItemRemove on a login item with the yellow warning triangle returns -50 and doesn't work. There is thus no programmatic way to clean invalid login items for the user. They have to manually click the minus button.

So for AltTab I fixed the crash when going through the items and finding one without URL, but I still can't clean old invalid items.

## [3.3.2](v3.3.1...v3.3.2) (2020-04-02) ### Bug Fixes * crashed if an invalid login item existed (closes [#202](#202)) ([48d5d63](48d5d63))

lwouis added the bug Something isn't working label Apr 2, 2020

lwouis mentioned this issue Apr 2, 2020

Add preference: disable mouse hover on the thumbnails #125

Closed

ghost mentioned this issue Apr 2, 2020

Phantom windows created by app Optimus Player #200

Closed

lwouis added a commit that referenced this issue Apr 2, 2020

fix: blind fix trying to guess root cause of #202

44f01f3

lwouis added a commit that referenced this issue Apr 2, 2020

fix: blind fix trying to guess root cause of #202

fb4fe11

lwouis added a commit that referenced this issue Apr 2, 2020

fix: crashed if an invalid login item existed (closes #202)

f5a2a37

lwouis closed this as completed in 48d5d63 Apr 2, 2020

lwouis pushed a commit that referenced this issue Apr 2, 2020

chore(release): 3.3.2 [skip ci]

6d3faa9

## [3.3.2](v3.3.1...v3.3.2) (2020-04-02) ### Bug Fixes * crashed if an invalid login item existed (closes [#202](#202)) ([48d5d63](48d5d63))

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v3.3.0 crashed and can no longer be started #202

v3.3.0 crashed and can no longer be started #202

mrc247-DE commented Apr 2, 2020

lwouis commented Apr 2, 2020 •

edited

Loading

mrc247-DE commented Apr 2, 2020

lwouis commented Apr 2, 2020

janbl commented Apr 2, 2020

lwouis commented Apr 2, 2020

lwouis commented Apr 2, 2020

janbl commented Apr 2, 2020

zoomosis commented Apr 2, 2020 •

edited

Loading

ghost commented Apr 2, 2020

lwouis commented Apr 2, 2020

lwouis commented Apr 2, 2020

janbl commented Apr 2, 2020

ghost commented Apr 2, 2020

mrc247-DE commented Apr 2, 2020

lwouis commented Apr 2, 2020 •

edited

Loading

lwouis commented Apr 2, 2020

zoomosis commented Apr 2, 2020

janbl commented Apr 2, 2020

lwouis commented Apr 2, 2020 •

edited

Loading

janbl commented Apr 2, 2020

lwouis commented Apr 2, 2020

janbl commented Apr 2, 2020

lwouis commented Apr 2, 2020

v3.3.0 crashed and can no longer be started #202

v3.3.0 crashed and can no longer be started #202

Comments

mrc247-DE commented Apr 2, 2020

lwouis commented Apr 2, 2020 • edited Loading

mrc247-DE commented Apr 2, 2020

lwouis commented Apr 2, 2020

janbl commented Apr 2, 2020

lwouis commented Apr 2, 2020

lwouis commented Apr 2, 2020

janbl commented Apr 2, 2020

zoomosis commented Apr 2, 2020 • edited Loading

ghost commented Apr 2, 2020

lwouis commented Apr 2, 2020

lwouis commented Apr 2, 2020

janbl commented Apr 2, 2020

ghost commented Apr 2, 2020

mrc247-DE commented Apr 2, 2020

lwouis commented Apr 2, 2020 • edited Loading

lwouis commented Apr 2, 2020

zoomosis commented Apr 2, 2020

janbl commented Apr 2, 2020

lwouis commented Apr 2, 2020 • edited Loading

janbl commented Apr 2, 2020

lwouis commented Apr 2, 2020

janbl commented Apr 2, 2020

lwouis commented Apr 2, 2020

lwouis commented Apr 2, 2020 •

edited

Loading

zoomosis commented Apr 2, 2020 •

edited

Loading

lwouis commented Apr 2, 2020 •

edited

Loading

lwouis commented Apr 2, 2020 •

edited

Loading