Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controls tab layout broken on macOS 10.12 Sierra #522

Closed
lwouis opened this issue Aug 11, 2020 · 4 comments
Closed

Controls tab layout broken on macOS 10.12 Sierra #522

lwouis opened this issue Aug 11, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@lwouis
Copy link
Owner

lwouis commented Aug 11, 2020

Describe the bug

On macOS 10.12 Sierra, the app has 2 issues:

  • The app icon isn't shown properly
    image
    Note that the icon is correct in the permission panel:
    image

  • The Controls tab layout is broken
    image
@lwouis lwouis added the bug Something isn't working label Aug 11, 2020
@lwouis
Copy link
Owner Author

lwouis commented Aug 11, 2020 •
edited
Loading

Here are the things I tried to get the app icon to work on Sierra:

* Generate the .icns with iconutil to test if this wasn't a regression of #169
* Use CFBundleIconFile with the full name with extension app-icon.icns
* Use CFBundleIconFile with the default name AppIcon
* Use CFBundleIconName instead or in addition to CFBundleIconFile

I don't get it. I downloaded AppCleaner and Rectangle to compare how other apps do it, and then do literally the same way, yet their icons display.

Nevermind, the issue was that Sierra doesn't support the 1024x1024 icon size. When using a smaller 512x512, it displays properly.

lwouis added a commit that referenced this issue Aug 12, 2020
@lwouis
fix: app icon was not showing on macos 10.12 (see #522)
d9c9414
@lwouis lwouis changed the title App icon not showing, and Controls tab layout broken on macOS 10.12 Sierra Controls tab layout broken on macOS 10.12 Sierra Aug 13, 2020
lwouis added a commit that referenced this issue Aug 18, 2020
@lwouis
fix: app icon was not showing on macos 10.12 (see #522)
2a45dec
lwouis pushed a commit that referenced this issue Aug 18, 2020
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
034d490 
# [5.0.0](v4.19.0...v5.0.0) (2020-08-18)

### Bug Fixes

* app icon was not showing on macos 10.12 (see [#522](#522)) ([2a45dec](2a45dec))
* battle.net installer and wow were not showing in alt-tab ([793b10b](793b10b)), closes [#536](#536)
* portuguese from portugal was shown to brazil users ([e54c2de](e54c2de))
* rare crash when the os was not providing the current space id ([cf05044](cf05044))
* rewrote the preference window to fix crashes and jank (closes [#502](#502)) ([f9f5b8a](f9f5b8a))

### Features

* change default key to select window from `return` to `space` ([eec694e](eec694e))
* complete rewrite of the keyboard support (closes [#157](#157)) ([d3253ba](d3253ba))
* show notification badges on top of app icons (closes [#523](#523)) ([fb62834](fb62834))
* update portuguese (brazil) localization ([726acd3](726acd3))
* updated japanese localization ([36c7b0a](36c7b0a))

### BREAKING CHANGES

* the previous keyboard support implementation was not working if any app on the system activated Secure Input and didn't turn it off. This is a major hurdle for most global shortcut apps. This update introduces a new implementation which is unaffected by Secure Input. AltTab shortcuts should now work reliably
@lwouis
Copy link
Owner Author

lwouis commented Sep 25, 2020

I can confirm that the layout issue in the Preferences > Controls is still there in 6.7.0 on Sierra.

@lwouis
Copy link
Owner Author

lwouis commented Apr 21, 2021

Still happening on 6.21.2

@lwouis lwouis mentioned this issue Nov 13, 2021
Closed
@lwouis
Copy link
Owner Author

lwouis commented May 28, 2022

Closing this as subsumed by #351

@lwouis lwouis closed this as completed May 28, 2022
@lwouis lwouis mentioned this issue Oct 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lwouis