-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all-projects
support for network zones
#712
Comments
@stgraber Can I get this one assigned? |
Yep, done! |
Sorry, been busy this week but I've just began working on this this morning. Can you provide some information on how can I test if my implementation was correct? Specifically for functions like |
In that case, I should be able to do |
Do I have an incorrect configuration because when I run
After doing some debugging, it seems that EDIT: Here's more information
From SQL:
|
What's the output of |
|
Are you sure you don't have any modifications to your client or daemon? I just tried running my commands from #712 (comment) in our demo sandbox (https://linuxcontainers.org/incus/try-it/) and it worked the same it does on my machine. |
I installed incus from source on my ubuntu VM following the steps specified at install from source. I then set it to minimal set up using |
What's the output of |
|
Okay, so client side looks correct and your server is unmodified? |
I tried the output on my end after adding support for the --all-projects flag. I noticed that I could not replicate your output so I created a new branch and copied the main incus repo and tried to see if I can get the output from there, but I couldn't. |
There must be something unclean with your daemon or your system, I just tried to replicate your issue in a clean Ubuntu VM and I still get the expected behavior here.
|
Hmm, interesting. I'll push my commits on a separate branch and do a full reinstall. I'll see if that works. |
I made the pull request (#749) but seems that there are some documentation issues. Mainly when I commit to my forked repo the changes have indentation issues. Is there a way to resolve this as I've never seen this issue before. |
Add all-projects support for network zones #712
Yeah, I'll make sure to put comments in the future and run the necessary checks for documentation. I also appreciate you taking the time to guide us since we don't have much experience working on large codebases! |
Similar to the work that's been done on instances, images, storage volumes and more, it'd be good to support the
?all-projects=true
URL parameter for/1.0/network-zones
.To do this, we'll need:
network_zones_all_projects
)client
all-projects=true
innetworkZonesGet
--all-projects
flag inincus network zone list
(cmd/incus)The text was updated successfully, but these errors were encountered: