incusd/device/disk: Allow relative paths within custom volumes #1092
Commits on Aug 8, 2024
-
Signed-off-by: Stéphane Graber <[email protected]>
-
incusd/device/disk: Allow relative paths within custom volumes
The general logic is pretty straightforward, we allow the `source` property to include both the volume name and then a relative path to that volume. The tricky part is to do this safely as the user will be in control of the volume and so can create dangerous symlinks in there, trying to trick us into reading data from the host. Carefuly use of Openat2 allows us to restrict resolution in a race-free way. Closes lxc#993 Signed-off-by: Stéphane Graber <[email protected]>
-
doc/devices_disk: Mention sub-paths
Signed-off-by: Stéphane Graber <[email protected]>
-
Signed-off-by: Stéphane Graber <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.