Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added text on the difference between containers and VMs #190

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

simos
Copy link
Contributor

@simos simos commented Oct 23, 2023

Differences between application/system containers and VMs.

@simos simos requested a review from stgraber as a code owner October 23, 2023 19:39
@github-actions github-actions bot added the Documentation Documentation needs updating label Oct 23, 2023
Copy link
Contributor

@ShalokShalom ShalokShalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, simos :)

@stgraber
Copy link
Member

stgraber commented Nov 1, 2023

Hey there, the reason I didn't review this before was because I left some comments on the PR from @ShalokShalom which was a subset of this PR.

So I was planning on having that one addressed and merged, then have this PR rebased on it and merged.

As that other PR has since been closed, I'll spend a bit of time to manually apply the suggested changes to the first commit in this PR, then review the second commit and hopefully get this merged.

@stgraber stgraber force-pushed the vm-containers-differences branch 2 times, most recently from f4e7ac7 to 2e6556a Compare November 25, 2023 04:12
@stgraber stgraber merged commit e510a1d into lxc:main Nov 25, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating
Development

Successfully merging this pull request may close these issues.

3 participants