Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs windows install update #407

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Conversation

nunix
Copy link
Contributor

@nunix nunix commented Jan 19, 2024

Incus has now a winget package available and the Windows installation docs have been updated with the instructions to install Incus with winget.

ps: I tried using stacked tabs, but the result was not good, so that's why the instructions are stacked.

ps2: while running the make doc from Ubuntu on WSL (what else?), I came across a package missing: python3.10-venv. Nothing critical, more a FYI.

Signed-off-by: Nuno do Carmo [email protected]

@nunix nunix requested a review from stgraber as a code owner January 19, 2024 16:49
@github-actions github-actions bot added the Documentation Documentation needs updating label Jan 19, 2024
@stgraber
Copy link
Member

@nunix hey there, can you update your commit messages to include the Signed-off-by: Name <email> line required by the DCO?

@stgraber stgraber added the Incomplete Waiting on more information from reporter label Jan 19, 2024
@nunix nunix force-pushed the docs-windows-install-update branch 2 times, most recently from eb04aa3 to 6e91ec5 Compare January 20, 2024 21:45
@nunix
Copy link
Contributor Author

nunix commented Jan 20, 2024

I could amend the 2 last commits (one being the update with the latest changes).
I followed some docs to update the first commit, but not sure if it applied it correctly. If not, can I kindly ask you if you know how to update the commit message for e600471.

Incus has now a [winget package](microsoft/winget-pkgs#131752) available
and the Windows installation docs have been updated with the instructions to install Incus with winget.

PS: I tried to used nested tabs, but the result was not good, so that's why the instructions are stacked.
PS2: While running the `make doc` from Ubuntu on WSL (what else?), I came across a package missing: `python3.10-venv`. Nothing critical, more a FYI.

Signed-off-by: Nuno do Carmo <[email protected]>
@stgraber
Copy link
Member

All good, I did a quick rebase of that branch, merged the two changes into the first commit and carried-over the Signed-off-by. Should be good to go once the doc tests clear.

Signed-off-by: Stéphane Graber <[email protected]>
@stgraber stgraber merged commit 91fb5c0 into lxc:main Jan 21, 2024
25 checks passed
@nunix nunix deleted the docs-windows-install-update branch January 21, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating Incomplete Waiting on more information from reporter
Development

Successfully merging this pull request may close these issues.

2 participants