incusd/instances: Don't bypass instance limit check #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes lxc#463 Signed-off-by: Stéphane Graber <[email protected]>
hallyn
approved these changes
Feb 18, 2024
tomponline
added a commit
to canonical/lxd
that referenced
this pull request
Sep 4, 2024
User reported in lxc/incus#463 that project limits were not being enforced on the cluster member in direct communication with the client during instance creation. ~I also noticed that the limit checks were being skipped based on the value of the [`User-Agent` header](d6871e4), which is spoofable. This pushes the limits check back to the target cluster member.~ Contains cherry-picks from lxc/incus#505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #463