incusd/instance/qemu: Cap hotplug CPU slots to 64 #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QEMU doesn't like dealing with more than 240 hotplug CPU slots and some OS struggle with more than 64, so put a cap to the max exposed CPUs to 64 unless the user has purposefully exposed more. Signed-off-by: Stéphane Graber <[email protected]> Sponsored-by: ActivePort (https://www.activeport.com.au) Signed-off-by: Stéphane Graber <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]>
This generally improves the error handling around finding processes and works around a Go change in tip. Signed-off-by: Stéphane Graber <[email protected]>
This generally improves the error handling around finding processes and works around a Go change in tip. Signed-off-by: Stéphane Graber <[email protected]>
|
Adding a couple of extra changes in this one to fix some test failures. |
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QEMU doesn't like dealing with more than 240 hotplug CPU slots and some OS struggle with more than 64, so put a cap to the max exposed CPUs to 64 unless the user has purposefully exposed more.
Sponsored-by: ActivePort (https://www.activeport.com.au)