incusd/instance/common: Fix CanMigrate mutating devices #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was leading to very odd validation errors in some cases if the instance being considered as part of a cluster restore happened to have a network device that would get an otherwise restricted key be internally set. The root of the issue was that CanMigrate didn't operate against a copy of the devices but would instead mutate the whole devices config, which would then trigger the validation error when sent through the devices logic for the second time as part of startup. This issue would only hit if: - The setup is clustered - The cluster is evacuated with action=stop - The user askes for the cluster member to be restored - The cluster member has one or more instances using a device that internally expands its configuration (like an OVN network card). - Those instances process such a device prior to any other check failing CanMigrate. - One or more of those instances are local to the server performing the check. Signed-off-by: Stéphane Graber <[email protected]> Sponsored-by: Buddy (https://buddy.works)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was leading to very odd validation errors in some cases if the instance being considered as part of a cluster restore happened to have a network device that would get an otherwise restricted key be internally set.
The root of the issue was that CanMigrate didn't operate against a copy of the devices but would instead mutate the whole devices config, which would then trigger the validation error when sent through the devices logic for the second time as part of startup.
This issue would only hit if:
Sponsored-by: Buddy (https://buddy.works)