Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to JWT authentication #694

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Improvements to JWT authentication #694

merged 5 commits into from
Mar 28, 2024

Conversation

stgraber
Copy link
Member

@stgraber stgraber commented Mar 28, 2024 •
edited
Loading

Includes #693 and adds:

  • Simplification of tls2jwt
  • Re-ordering of arguments in tls2jwt to be the usual crt and then key
  • Update tests to match
  • Update server-side logic to not be RSA-specific
  • Update server-side logic to be closer to our usual code-style, remove a type-cast and add a couple more checks

Closes #693

@tych0 tych0 merged commit 9da336e into lxc:main Mar 28, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stgraber @tych0 @mikerobski