incusd/project: Allow managed volumes under "allow" #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently three valid values for `restricted.devices.disk`. `block` will block everything, `managed` allows only managed volumes and `allow` allows not only managed volumes but also other types like shared host paths. When under `allow`, `restricted.devices.disk.paths` can be used to limit the host paths that can be passed into the instance. But that particular restriction should only apply to unmanaged volumes. Closes lxc#706 Signed-off-by: Stéphane Graber <[email protected]>
|
Wow, thanks for the speedy patch! I've rebuilt incus 0.7 with this patch cherry-picked and it appears to solve the issue. I have |
hallyn
approved these changes
Mar 30, 2024
tomponline
added a commit
to canonical/lxd
that referenced
this pull request
Sep 4, 2024
See [the docs](https://documentation.ubuntu.com/lxd/en/latest/reference/projects/#project-restricted:restricted.devices.disk) for disk device restrictions. This PR prevents checking the `restricted.devices.disk.paths` for managed devices when `restricted.devices.disk: allow`. Contains cherry-picks from lxc/incus#708
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently three valid values for
restricted.devices.disk.blockwill block everything,managedallows only managed volumes andallowallows not only managed volumes but also other types like shared host paths.When under
allow,restricted.devices.disk.pathscan be used to limit the host paths that can be passed into the instance.But that particular restriction should only apply to unmanaged volumes.
Closes #706