Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop networks during cluster evacuations #747

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Stop networks during cluster evacuations #747

merged 2 commits into from
Apr 19, 2024

Conversation

Abhiram824
Copy link
Contributor

@Abhiram824 Abhiram824 commented Apr 12, 2024 •
edited by stgraber
Loading

Closes #340

@Abhiram824 Abhiram824 mentioned this pull request Apr 12, 2024
Closed
stgraber
stgraber reviewed Apr 12, 2024
View reviewed changes
cmd/incusd/api_cluster.go Outdated Show resolved Hide resolved
stgraber
stgraber reviewed Apr 12, 2024
View reviewed changes
cmd/incusd/api_cluster.go Outdated Show resolved Hide resolved
stgraber
stgraber reviewed Apr 12, 2024
View reviewed changes
cmd/incusd/api_cluster.go Outdated Show resolved Hide resolved
@stgraber
Copy link
Member

On top of the few comments left in-line, note that your commit messages are missing the Signed-off-by line that we required for all commits (see CONTRIBUTING.md).

You can usually get that line added to the current commit with git commit --amend -s, assuming a properly configured git client.

@Abhiram824
Copy link
Contributor Author

Hello, thanks for the feedback! Made updates to the PR

@stgraber
Copy link
Member

Okay, got this one ready for Github testing and merging, I've done:

  • Merged all the commits together
  • Applied the result of gofmt -s -w ./
  • Removed a TODO comment that was leftover
  • Removed duplicate networkStartup call in restoreClusterMember (only needed at the start)
  • Reworded the comments a bit.
  • Reworded the commit message a bit.
  • Ran make static-analysis and cleaned up some new-line issues in daemon.go

@stgraber stgraber marked this pull request as ready for review April 19, 2024 02:33
@stgraber stgraber changed the title cmd/incusd: initial changes to disable ovn gateway chassis when evacuated (WIP) Stop networks during cluster evacuations Apr 19, 2024
@stgraber stgraber merged commit f2e3d04 into lxc:main Apr 19, 2024
25 checks passed
@MggMuggins MggMuggins mentioned this pull request Aug 26, 2024
Merged
tomponline added a commit to canonical/lxd that referenced this pull request Aug 27, 2024
@tomponline
lxd: Disable networks during evacuation (from Incus) (#13985)
16eab51 
Stop networks when a cluster member has been evacuated.

Includes cherry-picks from lxc/incus#747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable OVN gateway chassis when evacuated
2 participants
@Abhiram824 @stgraber