-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ZFS mirror/striping #754
Conversation
General structure looks good, just a few styling nits and some smaller bits that need tweaking/fixing. You should also add an extra commit, |
010d634
to
d1431ec
Compare
eb8165a
to
b1412e3
Compare
Signed-off-by: Parm Gill <[email protected]>
521a8c8
to
6298f69
Compare
Just did a quick rebase, merged two commits together and re-titled the commits as well as ran Should be all good now, just waiting for Github to run all the tests. Thanks! |
The documentation test is failing due to |
Ah yeah, you probably need to escape vdev as it's not a dictionary word and config indeed needs to become configuration. Please make those two edits directly in the doc commit then when things pass on Github I can merge it. I'm on my phone for the rest of the day here so can't directly edit commits. |
6298f69
to
339bc81
Compare
It is done. |
The api-extensions.md fix needed to go in the api: commit, not the doc: commit, sorry :) |
Signed-off-by: Parm Gill <[email protected]>
…doc/reference/storage_zfs.md Signed-off-by: Parm Gill <[email protected]>
Closes lxc#752 Signed-off-by: Parm Gill <[email protected]>
339bc81
to
e375d8b
Compare
Just fixed it. Sorry, I should have done it that way the first time. A workflow where commit message and contents are tightly integrated with CI is new to me. |
This pull request resolves issue #752
Summary:
vdev
types (mirror
,raidz1
andraidz2
). Defaultvdev
type,stripe
, is already supported.